feat: fall back to module resolution when relative imports fail - #198
Open
kherock wants to merge 1 commit into
Open
feat: fall back to module resolution when relative imports fail#198kherock wants to merge 1 commit into
kherock wants to merge 1 commit into
Conversation
kherock
force-pushed
the
fallback-module-resolution
branch
from
January 16, 2022 05:15
8dd01ab to
3efaa44
Compare
kherock
marked this pull request as ready for review
January 16, 2022 05:16
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
==========================================
- Coverage 99.63% 99.54% -0.09%
==========================================
Files 36 36
Lines 1083 1089 +6
Branches 318 319 +1
==========================================
+ Hits 1079 1084 +5
- Misses 4 5 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@Anidetrix (awesome to see that you're back!) I just rebased this and would appreciate getting it in an upcoming release. The implementation here should be fully backwards-compatible. |
|
@Anidetrix This would be very helpful to get in a release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #187. These changes enable developers to import sass by the same resolution logic that webpack's sass-loader uses.